Fix AxisAnalysis to avoid out of bound access.#3832
Merged
Conversation
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Contributor
Author
|
Rebase once PR #3816 lands |
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
whitneywhtsang
approved these changes
Apr 4, 2025
etiotto
added a commit
that referenced
this pull request
Apr 7, 2025
Enable the tutorial `09-persistent-matmul` and run it with both tensor of ptrs (`matmul_kernel_persistent`) and with tensor descriptors (`matmul_kernel_descriptor_persistent`). The latter kernel is internally translated into blocked ptrs. Note: rebase after PRs #3817 and #3832 lands. --------- Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
david-hls
pushed a commit
to david-hls/intel-xpu-backend-for-triton
that referenced
this pull request
Jun 18, 2025
This is a follow up PR of intel#3832 `wave` has been replaced with `warp` for the consistency between GPUs. Unfortunately there are still remaining use of `wave` in the code as below, although I've tried to minimize it. ## Referencing AMD features (HIP API or AMDGPU) third_party/amd/backend/include/hip/: third_party/amd/backend/include/roctracer/: third_party/amd/backend/include/has/*: - Cannot completely replace waves because the definition comes from outside e.g., __AMDGCN_WAVEFRONT_SIZE, hsa_wavefront_info_t - Mixing up `warp` and `wave` together in the same place could be even worse. ## Using amdgpu compiler option third_party/amd/backend/compiler.py: python/tutorials/03-matrix-multiplication.py: python/tutorials/06-fused-attention.py: - `waves_per_eu` which is supposed to mapped to a CLANG attribute `amdgpu-waves-per-eu` - It is AMD only option and makes better sense to keep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #3830.