[UT] Automatically generate skiplist when on a new platform#1596
Merged
Conversation
AshburnLee
force-pushed
the
lijunhui/auto-skiplist
branch
from
020f727 to
0b92dea
Compare
AshburnLee
changed the title
pbchekin
reviewed
Jul 10, 2024
| TRITON_TEST_REPORTS=true | ||
| source ${TRITON_PROJ}/scripts/pytest-utils.sh | ||
|
|
||
| # core tests |
Contributor
There was a problem hiding this comment.
Is it possible to use the existing test-triton.sh to run the tests? It would be nice to have it in one place (actually, we have another similar code in the CI workflow, but having it in 3 places it would be overkill, IMHO).
Author
There was a problem hiding this comment.
Done, reused test-triton.sh. Plus interpreter test is enabled from CI but it was not in test-triton.sh, so I add interpreter test.
AshburnLee
force-pushed
the
lijunhui/auto-skiplist
branch
from
0b92dea to
655ac14
Compare
AshburnLee
force-pushed
the
lijunhui/auto-skiplist
branch
from
655ac14 to
3a2b234
Compare
pbchekin
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core Triton is a small number of people, and we receive many PRs (thank
you!). To help us review your code more quickly, if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.
Complete the following tasks before sending your PR, and replace
[ ]with[x]to indicate you have done them.I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsThis is for skiplists generation.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)
Functionality
This PR fix #1423
Use
./scripts/automate_skiplist.sh ${NEW_PLATFORM}gives you./scripts/skiplist/${NEW_PLATFORM}/....txt