Merged
Conversation
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
whitneywhtsang
force-pushed
the
whitneywhtsang/cconv
branch
from
b7b9bfd to
ef0f30d
Compare
victor-eds
reviewed
Jun 3, 2024
victor-eds
left a comment
victor-eds
left a comment
There was a problem hiding this comment.
Maybe we can reuse createDeviceFunctionCall, passing the passthrough attributes as an argument, so we don't need to set cconv in so many places in the code? LGTM as is anyway.
etiotto
approved these changes
Jun 3, 2024
victor-eds
approved these changes
Jun 3, 2024
Contributor
Author
In general, I think it is a good idea to have one common function to create all device function. Since we are going to change GenISA usage to OCL functions soon, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address code review comment: #1214 (comment)