Skip to content

Add Wave ops in warp reduction.#1210

Closed
chengjunlu wants to merge 2 commits intollvm-targetfrom
chengjun/llvm-target-add-wave-op
Closed

Add Wave ops in warp reduction.#1210
chengjunlu wants to merge 2 commits intollvm-targetfrom
chengjun/llvm-target-add-wave-op

Conversation

@chengjunlu
Copy link
Copy Markdown
Contributor

Use the GenISA WaveAll and WaveCluster in warp horizontal reduce.

@chengjunlu chengjunlu force-pushed the chengjun/llvm-target-add-wave-op branch from f0a50a6 to e3a9e4b Compare May 30, 2024 04:12
@chengjunlu chengjunlu marked this pull request as draft May 30, 2024 07:30
@etiotto
Copy link
Copy Markdown
Contributor

etiotto commented May 30, 2024

I think we should have an operation in the TritonGEN dialect for WaveAll and WaveCluster. I discussed the design of that operation yesterday with @whitneywhtsang. I'm hoping she can create that operation and then we generate it in Triton.

@FMarno
Copy link
Copy Markdown
Contributor

FMarno commented May 30, 2024

I think we should have an operation in the TritonGEN dialect for WaveAll and WaveCluster. I discussed the design of that operation yesterday with @whitneywhtsang. I'm hoping she can create that operation and then we generate it in Triton.

It will likely also be helpful to add the WavePrefix intrinsic for scans (going by the small bit of documentation).

@chengjunlu
Copy link
Copy Markdown
Contributor Author

I think we should have an operation in the TritonGEN dialect for WaveAll and WaveCluster. I discussed the design of that operation yesterday with @whitneywhtsang. I'm hoping she can create that operation and then we generate it in Triton.

I will create a new PR based on the TritonGen operation.

@chengjunlu
Copy link
Copy Markdown
Contributor Author

I think we should have an operation in the TritonGEN dialect for WaveAll and WaveCluster. I discussed the design of that operation yesterday with @whitneywhtsang. I'm hoping she can create that operation and then we generate it in Triton.

It will likely also be helpful to add the WavePrefix intrinsic for scans (going by the small bit of documentation).

I created an issue to track this new requirements.
#1216

@Dewei-Wang-sh
Copy link
Copy Markdown
Contributor

I think we should have an operation in the TritonGEN dialect for WaveAll and WaveCluster. I discussed the design of that operation yesterday with @whitneywhtsang. I'm hoping she can create that operation and then we generate it in Triton.

@whitneywhtsang @etiotto add an op in tritongen for attention, FYI.
Dewei-Wang-sh@8670e5c#diff-22fc078e0ae2b9f9c2ee859630bfbd1092802ce694665ffa78a27d0a6464fa01

@whitneywhtsang
Copy link
Copy Markdown
Contributor

I think we should have an operation in the TritonGEN dialect for WaveAll and WaveCluster. I discussed the design of that operation yesterday with @whitneywhtsang. I'm hoping she can create that operation and then we generate it in Triton.

@whitneywhtsang @etiotto add an op in tritongen for attention, FYI. Dewei-Wang-sh@8670e5c#diff-22fc078e0ae2b9f9c2ee859630bfbd1092802ce694665ffa78a27d0a6464fa01

I am working on #1214, will put you as reviewer once it is ready, so you can check if it misses any features you need for your case.

@Dewei-Wang-sh
Copy link
Copy Markdown
Contributor

I think we should have an operation in the TritonGEN dialect for WaveAll and WaveCluster. I discussed the design of that operation yesterday with @whitneywhtsang. I'm hoping she can create that operation and then we generate it in Triton.

@whitneywhtsang @etiotto add an op in tritongen for attention, FYI. Dewei-Wang-sh@8670e5c#diff-22fc078e0ae2b9f9c2ee859630bfbd1092802ce694665ffa78a27d0a6464fa01

I am working on #1214, will put you as reviewer once it is ready, so you can check if it misses any features you need for your case.

great, this is the design align to our current.

@chengjunlu chengjunlu force-pushed the chengjun/llvm-target-add-wave-op branch 2 times, most recently from dc58c5d to 4fed409 Compare May 31, 2024 06:09
@whitneywhtsang
Copy link
Copy Markdown
Contributor

The operator is added in TritonGEN dialect, please update the PR to use it.

@vlad-penkin vlad-penkin linked an issue Jun 3, 2024 that may be closed by this pull request
@chengjunlu chengjunlu force-pushed the chengjun/llvm-target-add-wave-op branch from 4fed409 to 3d0a0b9 Compare June 3, 2024 07:35
@chengjunlu chengjunlu closed this Jun 3, 2024
@chengjunlu chengjunlu deleted the chengjun/llvm-target-add-wave-op branch September 5, 2024 07:37
wdziurdz pushed a commit that referenced this pull request Apr 7, 2026
Automated merge of main-interim into main-cri. Do not squash!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GEN] Add Wave[All|Clustered] operator

5 participants