Skip to content

[UT] add skiplist for PVC w/ rolling driver#1093

Closed
AshburnLee wants to merge 1 commit into
llvm-targetfrom
lijunhui/pvc_skiplist
Closed

[UT] add skiplist for PVC w/ rolling driver#1093
AshburnLee wants to merge 1 commit into
llvm-targetfrom
lijunhui/pvc_skiplist

Conversation

@AshburnLee
Copy link
Copy Markdown

@AshburnLee AshburnLee commented May 11, 2024

Functionality

Renamed default to pvc_rolling as pvc with rolling is the default platform.
Request: #985
This PR add a skiplist for pytest enables skipping ‘SKIPPED’ cases in script/skiplist/pvc_rolling when the platform is PVC with Rolling driver.

Result

After the change of this PR, the test sessions with deselect files skip all the SKIPPED test cases.

@AshburnLee AshburnLee self-assigned this May 11, 2024
@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch 2 times, most recently from 33298aa to 5bcc566 Compare May 11, 2024 08:14
@AshburnLee AshburnLee requested review from gshimansky, pbchekin and vlad-penkin and removed request for pbchekin and vlad-penkin May 11, 2024 08:14
Comment thread scripts/capture-hw-details.sh Outdated
@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch from 5bcc566 to 5c28b69 Compare May 13, 2024 00:56
Comment thread scripts/pytest-utils.sh Outdated
Copy link
Copy Markdown
Contributor

@pbchekin pbchekin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not need to put the existing xfailed tests to the skiplist. We use skiplist for skipped tests instead. Also the default skiplist is for PVC with the rolling driver, no need to create a new one, instead consider renaming default to pvc-rolling.

Comment thread scripts/capture-hw-details.sh Outdated
@vlad-penkin vlad-penkin linked an issue May 13, 2024 that may be closed by this pull request
@AshburnLee
Copy link
Copy Markdown
Author

AshburnLee commented May 14, 2024

I think we do not need to put the existing xfailed tests to the skiplist. We use skiplist for skipped tests instead. Also the default skiplist is for PVC with the rolling driver, no need to create a new one, instead consider renaming default to pvc-rolling.

Oh, I may understand it wrong, I should have put skipped tests in the skiplist, not the xfailed. OK, will change that and renaming default file.

How about the xfailed cases? do we just leave it as it was? thansks @pbchekin

@pbchekin
Copy link
Copy Markdown
Contributor

How about the xfailed cases? do we just leave it as it was?

Yes

@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch 2 times, most recently from 67772d2 to e38cd31 Compare May 17, 2024 14:18
@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch from e38cd31 to a4f1ef4 Compare May 27, 2024 02:07
@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch 2 times, most recently from 639464c to 6ff3519 Compare June 6, 2024 02:00
@AshburnLee
Copy link
Copy Markdown
Author

AshburnLee commented Jun 10, 2024

How about approving this PR? Just change the skip list default name as 'pvc_rolling'? @vlad-penkin @pbchekin

@pbchekin
Copy link
Copy Markdown
Contributor

@AshburnLee please sync the PR with the target branch, there is a change to the skip list in #1310.

@yudongsi yudongsi force-pushed the lijunhui/pvc_skiplist branch from 6ff3519 to 401b2ec Compare June 11, 2024 15:49
@AshburnLee
Copy link
Copy Markdown
Author

@AshburnLee please sync the PR with the target branch, there is a change to the skip list in #1310.

Done, thanks~

@vlad-penkin
Copy link
Copy Markdown
Contributor

@AshburnLee similar comment, please take into the account this PR:

@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch from 401b2ec to 983b129 Compare June 12, 2024 02:31
@AshburnLee
Copy link
Copy Markdown
Author

@AshburnLee similar comment, please take into the account this PR:

Updated, thanks~

@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch 2 times, most recently from 79d9085 to f112089 Compare June 13, 2024 03:45
@AshburnLee
Copy link
Copy Markdown
Author

Please give approval @vlad-penkin thanks~

@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch from f112089 to 9f46837 Compare June 14, 2024 16:39
@pbchekin
Copy link
Copy Markdown
Contributor

No longer needed.

@pbchekin pbchekin closed this Jul 10, 2024
@pbchekin pbchekin deleted the lijunhui/pvc_skiplist branch July 10, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PVC skiplist for Rolling Driver

4 participants