[UT] add skiplist for PVC w/ rolling driver#1093
Conversation
33298aa to
5bcc566
Compare
5bcc566 to
5c28b69
Compare
pbchekin
left a comment
There was a problem hiding this comment.
I think we do not need to put the existing xfailed tests to the skiplist. We use skiplist for skipped tests instead. Also the default skiplist is for PVC with the rolling driver, no need to create a new one, instead consider renaming default to pvc-rolling.
Oh, I may understand it wrong, I should have put skipped tests in the skiplist, not the xfailed. OK, will change that and renaming default file. How about the xfailed cases? do we just leave it as it was? thansks @pbchekin |
Yes |
67772d2 to
e38cd31
Compare
e38cd31 to
a4f1ef4
Compare
639464c to
6ff3519
Compare
|
How about approving this PR? Just change the skip list default name as 'pvc_rolling'? @vlad-penkin @pbchekin |
|
@AshburnLee please sync the PR with the target branch, there is a change to the skip list in #1310. |
6ff3519 to
401b2ec
Compare
Done, thanks~ |
|
@AshburnLee similar comment, please take into the account this PR: |
401b2ec to
983b129
Compare
Updated, thanks~ |
79d9085 to
f112089
Compare
|
Please give approval @vlad-penkin thanks~ |
f112089 to
9f46837
Compare
|
No longer needed. |
Functionality
Renamed default to pvc_rolling as pvc with rolling is the default platform.
Request: #985
This PR add a skiplist for pytest enables skipping ‘SKIPPED’ cases inscript/skiplist/pvc_rollingwhen the platform is PVC with Rolling driver.Result
After the change of this PR, the test sessions with deselect files skip all the SKIPPED test cases.