add tile count label #596
Merged
add tile count label #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rojkov
reviewed
Feb 26, 2021
cmd/gpu_nfdhook/labeler.go
Outdated
There was a problem hiding this comment.
Now the function name doesn't fully reflect what it actually returns. I guess the return values should be documented somehow for better readability. Either in the doc string or by giving them names.
The rest looks good!
|
@uniemimu unit tests seem to be failing. can you have a look? |
Signed-off-by: Ukri Niemimuukko <[email protected]>
Oops. Fixed. |
mythi
approved these changes
Feb 26, 2021
bart0sh
approved these changes
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ukri Niemimuukko [email protected]