Skip to content

Conversation

dmitsh
Copy link
Contributor

@dmitsh dmitsh commented Jan 28, 2021

Signed-off-by: Dmitry Shmulevich [email protected]

Closes: #457

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitsh thanks!

I added a couple of thoughts to bettter integrate this with the existing functionality. What do you think?

@dmitsh dmitsh requested a review from kad as a code owner January 30, 2021 06:21
@dmitsh dmitsh requested a review from mythi January 30, 2021 06:23
@kad
Copy link
Member

kad commented Feb 1, 2021

Generally looks ok, but please squash commits like "typos"/"minor"

@dmitsh
Copy link
Contributor Author

dmitsh commented Feb 2, 2021

Generally looks ok, but please squash commits like "typos"/"minor"

done

Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mythi mythi merged commit 7561501 into intel:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SGX Extended resources

4 participants