QAT Gen4 #529
Merged
QAT Gen4 #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythi
force-pushed
the
qat-gen4-v2
branch
3 times, most recently
from
62ac3be to
7c504b5
Compare
The plugin now detects/accepts 4xxx and c4xxx devices too and defaults to those drivers that are part of Linux mainline. Signed-off-by: Mikko Ylinen <[email protected]>
Codecov Report
Continue to review full report at Codecov.
|
rojkov
reviewed
Dec 18, 2020
cmd/qat_plugin/dpdkdrv/dpdkdrv.go
Outdated
There was a problem hiding this comment.
Is the order of the drivers important here? I guess
for _, vfDriver := range append(dp.kernelVfDrivers, dp.dpdkDriver) {
would be more readable.
There was a problem hiding this comment.
We prefer devices that are already bound to the targeted driver. See: #146
The updated dp.scan() changes the way how VF devices are detected. The main reason for the change is to take into account cases where the QAT VF driver is not present in the system at all but only the PF driver is loaded (and the SR-IOV devices are are enabled). The rework also takes into account bare metal and VM deployments and adds a test case for checking the virtualized environment. Signed-off-by: Mikko Ylinen <[email protected]>
rojkov
reviewed
Dec 18, 2020
| vfdevID, err := dp.getDeviceID(vfBdf) | ||
| if err != nil { | ||
| klog.Warningf("Can't read sysfs for driver as Driver %s is not available: Skipping", driver) | ||
| return nil, errors.Wrapf(err, "Cannot obtain device ID for %s", vfBdf) |
There was a problem hiding this comment.
nit: no need to embed one more stack trace into the error. Can be fixed in a followup PR though as the existing code in the master branch does the same.
rojkov
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #451