Skip to content

Conversation

intelkevinputnam
Copy link
Contributor

Signed-off-by: Kevin Putnam [email protected]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot have this file without modifying Makefile. The default build target expects everything under cmd/ is a direcrory.

Do we need extensions.rst here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to /docs for now.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #468 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   57.98%   57.98%           
=======================================
  Files          28       28           
  Lines        2009     2009           
=======================================
  Hits         1165     1165           
  Misses        788      788           
  Partials       56       56           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff18b8a...a918b6c. Read the comment docs.

@mythi
Copy link
Contributor

mythi commented Sep 25, 2020

@intelkevinputnam thanks! Can you please squash the commits again. I'll try running & merging this on Monday.

@intelkevinputnam
Copy link
Contributor Author

@mythi Will do. FYI this PR does not have GitHub workflow for automated deployment.

@mythi mythi merged commit 9a3cf96 into intel:master Sep 27, 2020
@mythi
Copy link
Contributor

mythi commented Sep 27, 2020

tested a manual 'build' and checked the output. looks nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants