webhooks: move to admissionregistration.k8s.io/v1 #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
=======================================
Coverage 58.36% 58.36%
=======================================
Files 27 27
Lines 2337 2337
=======================================
Hits 1364 1364
Misses 916 916
Partials 57 57
Continue to review full report at Codecov.
|
|
This looks good. For OLM I had to remove CA injection for the |
With controller-gen 0.4.0, admissionregistration defaults to v1 API. Signed-off-by: Mikko Ylinen <[email protected]>
We currently build using trivialVersions=true and don't deal with multiversion APIs and their conversion webhooks. Therefore, drop the registration of the conversion webooks. Signed-off-by: Mikko Ylinen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
=======================================
Coverage 58.30% 58.30%
=======================================
Files 30 30
Lines 2094 2094
=======================================
Hits 1221 1221
Misses 808 808
Partials 65 65
Continue to review full report at Codecov.
|
rojkov
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With controller-gen 0.4.0, admissionregistration defaults to v1 API.
Fixes: #364
Note: I've manually tweaked
make generateoutput so keeping this in draft still.Signed-off-by: Mikko Ylinen [email protected]