Skip to content

Conversation

rojkov
Copy link
Contributor

@rojkov rojkov commented Apr 15, 2020

closes #317

@rojkov rojkov requested review from bart0sh, kad and mythi as code owners April 15, 2020 14:10
@mythi
Copy link
Contributor

mythi commented Apr 16, 2020

perhaps we should take #364 in this PR too?

@mythi
Copy link
Contributor

mythi commented Apr 16, 2020

can we document the steps to get 453ad1c easily done in DEVEL.md?

@bart0sh
Copy link
Member

bart0sh commented Apr 16, 2020

/LGTM & agree with @mythi requests

@rojkov
Copy link
Contributor Author

rojkov commented Apr 16, 2020

can we document the steps to get 453ad1c easily done in DEVEL.md?

Sure, I'll update DEVEL.md FWIW

Usually I follow this post https://www.openshift.com/blog/kubernetes-deep-dive-code-generation-customresources. Though it's assumed dep is used instead of go mod. The latter makes the steps look like black magic:

  1. bump up the deps,
  2. copy the repo to $GOPATH/srd/github.com/intel/...,
  3. put the boilerplate to the place k8s's codegen script expects it (no way to specify it as an option),
  4. run the script
  5. copy the generate code back to the original repository
  6. fix compilation issues.

Probably there's a better way.

@rojkov rojkov force-pushed the release-0.18 branch 2 times, most recently from 361b7aa to 7bcefa9 Compare April 16, 2020 12:02
@rojkov
Copy link
Contributor Author

rojkov commented Apr 16, 2020

perhaps we should take #364 in this PR too?

I tried that, but it turned out v1beta1 and v1 have substantial differences. Here's an example for the two versions
https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#create-a-customresourcedefinition
E2E tests fail if to change the version only. I'd rather fix the issue in a followup PR.

@mythi
Copy link
Contributor

mythi commented Apr 16, 2020

@rojkov OK, let's work on #364 separately

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please squash commits

@rojkov rojkov changed the title WIP: move to Kubernetes v1.18.1 API move to Kubernetes v1.18.2 API Apr 17, 2020
@rojkov
Copy link
Contributor Author

rojkov commented Apr 17, 2020

Oops, I didn't notice github automatically requested your reviews. Now it's ready for review.

bart0sh
bart0sh previously approved these changes Apr 17, 2020
@bart0sh
Copy link
Member

bart0sh commented Apr 17, 2020

@mythi can you merge?

@mythi
Copy link
Contributor

mythi commented Apr 17, 2020

the CI returns an error. perhaps retrigger the build to make sure it's OK?

@rojkov
Copy link
Contributor Author

rojkov commented Apr 17, 2020

the CI returns an error. perhaps retrigger the build to make sure it's OK?

It seems I don't have permissions to restart jenkins pipelines.

@mythi
Copy link
Contributor

mythi commented Apr 17, 2020

It seems I don't have permissions to restart jenkins pipelines.

I usually just force push with a new commit id.

Also fix the plugins and e2e tests
@bart0sh
Copy link
Member

bart0sh commented Apr 17, 2020

@mythi now it seems to be ready for merging.

@mythi mythi merged commit 96d9e64 into intel:master Apr 17, 2020
@tkhred tkhred mentioned this pull request Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt to K8s 1.18 API changes

3 participants