workflow: improve trivy vulnerability scanning #1929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fail trivy vuln scan cleanly and create a periodic trivy scan to upload results to Github's security. Signed-off-by: Tuomas Katila <[email protected]>
tkatila
force-pushed
the
workflow-improve-trivy-vuln-scan
branch
from
cdb56c6 to
7a34155
Compare
mythi
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail trivy vuln scan cleanly and create a periodic trivy scan to upload results to Github's security.
Trivy-action doesn't work too well when it's executed multiple times in the job. The env variables the action sets spill over to the next step and the step might be executed incorrectly. In our case, the "show report in human-readable format" actually just converted the json format back to json format and it didn't show the actual vulnerability in the action's logs.