Skip to content

labeler: fix false-failure with nfd file removal test #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024
Merged

labeler: fix false-failure with nfd file removal test #1856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cmd/internal/labeler/labeler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,11 @@ func TestCreateAndRun(t *testing.T) {

// Wait for the labeling timeout to trigger
if !waitForFileOp(root, nfdLabelBase, fsnotify.Remove, time.Second*2) {
t.Error("Run didn't remove label file")
// It's possible that removal happened before we started waiting.
// Only fail the test if the file still exists.
if _, err := os.Stat(nfdLabelFile); err == nil {
t.Error("Run didn't remove label file")
}
}
})
}
Expand Down
Loading