Skip to content

Conversation

tkatila
Copy link
Contributor

@tkatila tkatila commented Sep 20, 2024

Static scan notified that calloc's return value wasn't checked.

Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, this is last item in the code that was missing check for return value.

PS. There could be some define (e.g TEMP_ERROR_RET_VAL) in header for this magic value used (many times) in code:
return -999.0;

@tkatila
Copy link
Contributor Author

tkatila commented Sep 20, 2024

PS. There could be some define (e.g TEMP_ERROR_RET_VAL) in header for this magic value used (many times) in code: return -999.0;

That's a good point. I'll add it.

Sadly, Github's workers seem to be misbehaving today.

@mythi mythi merged commit 77320c3 into intel:main Sep 23, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants