This repository was archived by the owner on May 9, 2024. It is now read-only.
Replace dictionary proxies with nested dictionaries 14/N #699
+203
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbaden
approved these changes
Oct 12, 2023
ienkovich
force-pushed
the
ienkovich/nested-dict-14
branch
from
df5bda3 to
df7c082
Compare
Signed-off-by: ienkovich <ilya.enkovich@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support nested dictionaries in StringDictionary::getCompare.
This patch also fixes several bugs in this method. The logic around the comparison of
cache_index->indexwith zero is completely broken because the zero index has no special meaning at all. Added tests cover both nested dictionaries and these fixed bugs.