This repository was archived by the owner on May 9, 2024. It is now read-only.
Update to Calcite 1.35 (latest version) #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implicit Timestamp casts should increase, not reduce precision
|
@ienkovich @vlad-penkin any comments? |
ienkovich
approved these changes
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary changes to Calcite were in the parser. Some appear to be bug fixes (the changes around Timestamp casts make sense logically, whereas before we seemed to be inventing precision we didn't have). Others appear to be semantics (the cast removal in the interop query) that do not effect us, as the cast in that query appears to be a workaround. I believe the new aggregate call constructor is specified properly, but we will want to sanity test with modin after this is merged.
I updated some Java packages associated with Calcite but left most of those at their current versions pending @vlad-penkin's analysis.