Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Fix conda in a minimal way #687

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix conda in a minimal way #687

merged 1 commit into from
Oct 4, 2023

Conversation

leshikus
Copy link
Contributor

@leshikus leshikus commented Oct 4, 2023

Subj

@leshikus leshikus requested a review from alexbaden October 4, 2023 13:40
Devjiu
Devjiu reviewed Oct 4, 2023
View reviewed changes
.github/workflows/build.yml
@@ -99,7 +99,7 @@ jobs:
- name: Configure and build
run: |
conda info --env
conda run --no-capture-output -n omnisci-dev sh -vx omniscidb/scripts/conda/build.sh ${{ inputs.options }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove -vx in most of scripts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-vx does not work, -v -x still works

alexbaden
alexbaden approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@alexbaden alexbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the build, so let's get it merged. Any idea what changed in conda to break this flag?

@leshikus leshikus merged commit 2107810 into main Oct 4, 2023
@leshikus leshikus deleted the lesh/minor-conda-fix branch October 4, 2023 16:14
@leshikus
Copy link
Contributor Author

leshikus commented Oct 4, 2023

@alexbaden they started using a faulty command line parser, -vx in any place breaks it while -v -x still works; I don't think they would fix it because the problem is quite specific

@leshikus
Copy link
Contributor Author

leshikus commented Oct 4, 2023

I removed -vx because our script calls set -vx itself

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Devjiu Devjiu Devjiu left review comments

@alexbaden alexbaden alexbaden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leshikus @alexbaden @Devjiu