This repository was archived by the owner on May 9, 2024. It is now read-only.
Update to LLVM 15 and Support LLVM 16 on Windows #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbaden
force-pushed
the
alex/llvm16_windows
branch
8 times, most recently
from
0b68013 to
ee1f220
Compare
Update cache restore code in Windows Test workflow
alexbaden
force-pushed
the
alex/llvm16_windows
branch
from
ee1f220 to
4135a85
Compare
alexbaden
changed the title
alexbaden
requested review from
kurapov-peter,
gshimansky,
ienkovich and
leshikus
gshimansky
approved these changes
Sep 26, 2023
kurapov-peter
approved these changes
Sep 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates CI to use LLVM 15 and adds build support for LLVM 16.
For CI, the main change is to set VSINSTALLDIR so LLVM picks it up for proper linking. To do this, I use the
vswhere.exeapplication which is installed with visual studio. Presumably this will survive version updates. I also modified the cache getters/setters as the cache was not being used in the build step, previously. Finally, my initial plan was to go to LLVM 16 but I ran into some opaque pointer issues even with my workarounds, so we're at LLVM 15 but I kept the commits to add build support for 16.Interestingly my first run through the tests failed because I hit the same relocatable section error we've been seeing, so unfortunately LLVM 15 isn't fixing that one. Maybe 16 will.