This repository was archived by the owner on May 9, 2024. It is now read-only.
Remove implicit cast to size_t #634
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this reveals a bug of |
alexbaden
reviewed
Aug 16, 2023
| @@ -116,7 +116,7 @@ int64_t get_agg_initial_val(hdk::ir::AggType agg, | |||
| CHECK(!(type->isString() || type->isExtDictionary()) || | |||
| (agg == hdk::ir::AggType::kSingleValue || agg == hdk::ir::AggType::kSample)); | |||
| const auto byte_width = | |||
| enable_compaction | |||
| enable_compaction && type->size() > 0 | |||
There was a problem hiding this comment.
I am surprised this didn't cause errors earlier - is it possible for enable_compaction to ever be true here?
There was a problem hiding this comment.
Varlen aggregate type is used for TopK aggregate only. And in the code below we simply don't use byte_width for the TopK case.
There was a problem hiding this comment.
Varlen aggregate should also work for SAMPLE(varlen_type), though in that case the aggregation was a hack (we would just place the rowid of the chosen row in the aggregate slot)
ienkovich
approved these changes
Aug 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.