This repository was archived by the owner on May 9, 2024. It is now read-only.
Fix arrays fetch in ResultSetRegistry. #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ienkovich <[email protected]>
| @@ -1055,7 +1055,7 @@ size_t ResultSet::computeVarLenOffsets(size_t col_idx, int32_t* offsets) const { | |||
| } | |||
|
|
|||
| // Translate varlen value to its length. Return -1 for NULLs. | |||
| auto slot_val_to_length = [this, lazy_fetch, col_idx, type, target_info]( | |||
| auto slot_val_to_length = [this, lazy_fetch, col_idx, type, target_info, arr_elem_size]( | |||
There was a problem hiding this comment.
I'd change the name since you've modified it's meaning.
There was a problem hiding this comment.
I think the name still correctly describes the method's meaning. It gets a slot value and returns the corresponding array length in bytes.
kurapov-peter
approved these changes
Aug 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, NULL value for fixed-length arrays in TargetValue can be expressed in two different ways - nullopt and zero-length array. Only arrow converter supports both cases, fetch and contentToString don't cover both. This patch forces nullopt to be always used.
Also, this patch fixes the fetch of varlen arrays with lazy fetch.
Resolves #627