This repository was archived by the owner on May 9, 2024. It is now read-only.
Support TopK aggregate in RelAlgDagBuilder. #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurapov-peter
approved these changes
Aug 11, 2023
| arg1 = std::dynamic_pointer_cast<const hdk::ir::Constant>(sources[operands[1]]); | ||
| if (!arg1 || !arg1->type()->isInteger() || arg1->value().intval == 0) { | ||
| throw std::runtime_error( | ||
| "TOP_K's second parameter should be non-zero integer literl"); |
| @@ -49,6 +49,8 @@ const hdk::ir::Type* get_agg_type(hdk::ir::AggType agg_kind, | |||
| } | |||
| case hdk::ir::AggType::kSample: | |||
| return arg_expr->type(); | |||
| case hdk::ir::AggType::kTopK: | |||
| return ctx.arrayVarLen(arg_expr->type(), 4, false); | |||
There was a problem hiding this comment.
The call as well as the signature of the method is not clear at first glance.
alexbaden
approved these changes
Aug 12, 2023
Signed-off-by: ienkovich <[email protected]>
ienkovich
force-pushed
the
ienkovich/json-topk
branch
from
38e8c98 to
269038d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.