Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Add if_then_else to PyHDK query builder. #621

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

ienkovich
Copy link
Contributor

No description provided.

true_val: bool, int, float, str or QueryExpr
Value to use if condtion is True.
false_val: bool, int, float, str or QueryExpr
Value to use if condition is False.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a user, I'd be interested in what happens if the sizes of true_val and false_val are different. Could you add a short description of what's going to happen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note that values should have the same type.

@ienkovich ienkovich force-pushed the ienkovich/if-then-else branch from 7cedbd6 to ad6517e Compare August 8, 2023 16:10
Copy link
Contributor

@kurapov-peter kurapov-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@ienkovich ienkovich merged commit 72073c2 into main Aug 9, 2023
@ienkovich ienkovich deleted the ienkovich/if-then-else branch August 9, 2023 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants