This repository has been archived by the owner on May 9, 2024. It is now read-only.
Add support for bitwise operations. #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurapov-peter
suggested changes
Jul 3, 2023
|
|
||
| BuilderExpr bwOr(const BuilderExpr& rhs) const; | ||
| BuilderExpr bwOr(int val) const; | ||
| BuilderExpr bwOr(int64_t val) const; |
There was a problem hiding this comment.
Should we use explicit bit width everywhere? I'd expect either int32_t with int64_t or int with long long; the latter should be incorrect in our case.
There was a problem hiding this comment.
int and int64_t overloads match all other similar functions. We can use int32_t and int64_t instead, but it should be done globally then, not only for bitwise operations.
Signed-off-by: ienkovich <[email protected]>
ienkovich
force-pushed
the
ienkovich/bitwise
branch
from
51c9b4a
to
ac8cc25
Compare
kurapov-peter
approved these changes
Jul 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers C++ and PyHDK API but not Calcite.
Related to #542.