This repository was archived by the owner on May 9, 2024. It is now read-only.
Add missing destructor #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ienkovich
reviewed
Jun 28, 2023
omniscidb/L0Mgr/L0Mgr.cpp
Outdated
| @@ -114,6 +114,10 @@ ze_command_list_handle_t L0CommandList::handle() const { | |||
|
|
|||
| L0CommandList::~L0CommandList() { | |||
| // TODO: maybe return to pool | |||
| auto status = zeCommandListDestroy(handle_); | |||
| if (status) { | |||
| std::cerr << "Non-zero status for command list destructor" << std::endl; | |||
There was a problem hiding this comment.
No particular reason, just to stay consistent.
There was a problem hiding this comment.
I see. I still think moving from std::err to LOG(ERROR) in this file would be the right thing to do. In tests, ERROR log should be printed to stderr anyway.
ienkovich
approved these changes
Jun 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well... happens, I guess.