This repository was archived by the owner on May 9, 2024. It is now read-only.
Move window function pre-project creation to DAG canonicalization. #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ienkovich <[email protected]>
alexbaden
approved these changes
Jun 23, 2023
| dag.setNodes(std::move(nodes)); | ||
| } | ||
| } | ||
|
|
||
| } // namespace | ||
|
|
||
| void canonizeQuery(QueryDag& dag) { |
There was a problem hiding this comment.
I should have realized this before - but should this be canonicalizeQuery?
There was a problem hiding this comment.
Oops, sure it should.
Signed-off-by: ienkovich <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move DAG transformation for window functions we use in
RelAlgDagBuildertocanonizeQueryso that it's applied to both Calcite and QueryBuilder generated queries. Some minor functions were moved to the IR module.Resolves #541
Resolves #543