-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
Any specific tests for sh mem or existing set is enough?
Is it worth to be handled as a separate issue? |
Yes, we'll have some smem specific tests. Address space casts will be addressed separately. |
The pass rate is now decent, so this is ready for review. |
%no_skip = icmp ne i64 %val, %skip_val | ||
br i1 %no_skip, label %.noskip, label %.skip | ||
.noskip: | ||
%old = call i64 @agg_count(i64* %agg, i64 %val) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if shared_mem
is turned off? What function implementation do we fall back to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed the comment. I haven't tested it, but what should happen is it should emit the agg_count
from the "cpu" runtime module instead. BTW, I'm not sure if we need the option to disable shared memory at all :)
The PR adds proper code generation for Intel GPUs.
Notes:
genx.ll
module and its size is not checked for now.emitCall
would use the wrong runtime module. This is now fixed by patching the module triple upon extension module load.