Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Fixed Calcite processing of queries with APPROX_QUANTILE aggregation. #506

Merged
merged 1 commit into from
May 25, 2023

Conversation

AndreyPavlenko
Copy link
Contributor

The removed code seems redundant and it fails with "IllegalArgumentException: No enum constant org.apache.calcite.sql.SqlKind.APPROX_QUANTILE" if the query contains an APPROX_QUANTILE aggregation.

The stack trace:

java.lang.IllegalArgumentException: No enum constant org.apache.calcite.sql.SqlKind.APPROX_QUANTILE
        at java.lang.Enum.valueOf(Enum.java:273) ~[?:?]
        at org.apache.calcite.sql.SqlKind.valueOf(SqlKind.java:81) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at org.apache.calcite.rel.externalize.MapDRelJson.toOp(MapDRelJson.java:568) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at org.apache.calcite.rel.externalize.MapDRelJson.toAggregation(MapDRelJson.java:590) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at org.apache.calcite.rel.externalize.MapDRelJsonReader.toAggCall(MapDRelJsonReader.java:293) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at org.apache.calcite.rel.externalize.MapDRelJsonReader.access$500(MapDRelJsonReader.java:61) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at org.apache.calcite.rel.externalize.MapDRelJsonReader$2.getAggregateCalls(MapDRelJsonReader.java:175) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at org.apache.calcite.rel.core.Aggregate.<init>(Aggregate.java:228) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at org.apache.calcite.rel.logical.LogicalAggregate.<init>(LogicalAggregate.java:107) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
        at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?]
        at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
        at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) ~[?:?]
        at java.lang.reflect.Constructor.newInstance(Constructor.java:480) ~[?:?]
        at org.apache.calcite.rel.externalize.MapDRelJsonReader.readRel(MapDRelJsonReader.java:266) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at org.apache.calcite.rel.externalize.MapDRelJsonReader.readRels(MapDRelJsonReader.java:92) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at org.apache.calcite.rel.externalize.MapDRelJsonReader.read(MapDRelJsonReader.java:86) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at org.apache.calcite.prepare.MapDPlanner.optimizeRaQuery(MapDPlanner.java:229) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at com.mapd.calcite.parser.MapDParser.optimizeRAQuery(MapDParser.java:204) ~[calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]
        at com.mapd.parser.server.CalciteServerHandler.process(CalciteServerHandler.java:154) [calcite-1.0-SNAPSHOT-jar-with-dependencies.jar:?]

The removed code seems redundant and it fails with "IllegalArgumentException:
No enum constant org.apache.calcite.sql.SqlKind.APPROX_QUANTILE" if the query
contains an APPROX_QUANTILE aggregation.

Signed-off-by: Andrey Pavlenko <[email protected]>
Copy link
Contributor

@alexbaden alexbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, those values seem to be unused. Looks fine to me.

@alexbaden alexbaden merged commit c8d7d5d into intel:main May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants