This repository was archived by the owner on May 9, 2024. It is now read-only.
Enable multifrag result set tables by default. #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently found we don't enable multi-fragment result set tables by default and this function is actually broken. It is supposed to improve parallelism for some queries, so I want to get it fixed and enabled by default.
There are also some UNION ALL related changes included due to failed tests. It appears UNION ALL on scans doesn't work so I restricted it explicitly. And the code in
WorkUnitBuilder::computeInputColDescsis outdated and cannot properly handle inputs from different databases, so I fixed it as well.