Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Ignore logging options in ConfigBuilder. #474

Merged
merged 1 commit into from
May 13, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions omniscidb/ConfigBuilder/ConfigBuilder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

#include "ConfigBuilder.h"

#include "Logger/Logger.h"

#include <boost/crc.hpp>
#include <boost/program_options.hpp>

Expand Down Expand Up @@ -572,12 +574,20 @@ bool ConfigBuilder::parseCommandLineArgs(int argc,
opt_desc.add_options()("gtest_filter", "filters tests, use --help for details");
}

// Right now we setup logging independently. Until it's fixed, simply ignore logger
// options here.
logger::LogOptions log_opts("dummy_opts");
log_opts.set_options();

po::options_description all_opts;
all_opts.add(opt_desc).add(log_opts.get_options());

po::variables_map vm;
po::store(po::command_line_parser(argc, argv).options(opt_desc).run(), vm);
po::store(po::command_line_parser(argc, argv).options(all_opts).run(), vm);
po::notify(vm);

if (vm.count("help")) {
std::cout << opt_desc << std::endl;
std::cout << all_opts << std::endl;
return true;
}

Expand Down