Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Update HDK to support config structure + use latest jit-engine #46

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

alexbaden
Copy link
Contributor

No description provided.

Signed-off-by: ienkovich <ilya.enkovich@intel.com>
@alexbaden alexbaden marked this pull request as ready for review July 6, 2022 02:50
cdef bool g_enable_debug_timer

cdef extern from "omniscidb/Logger/Logger.h" namespace "logger":
cdef cppclass CLogOptions "logger::LogOptions":
CLogOptions(const char*)

cdef void CInitLogger "logger::init"(const CLogOptions &)

cdef extern from "omniscidb/Shared/Config.h":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tools to generate this from plain C structures?

@alexbaden
Copy link
Contributor Author

@kurapov-peter @Garra1980 @ienkovich I removed the pytest changes from this PR so we could get our main branches resynced. I put the pytest work in alex/pyhdk_github_actions for now.

explain_str = res.to_explain_str()
assert (explain_str[:15] == "IR for the CPU:")
assert explain_str[:15] == "IR for the CPU:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this python 2?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it works in 3rd, cool

Copy link
Contributor

@kurapov-peter kurapov-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexbaden alexbaden merged commit c385531 into main Aug 1, 2022
@alexbaden alexbaden deleted the alex_ilya/config branch August 1, 2022 03:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants