This repository was archived by the owner on May 9, 2024. It is now read-only.
Don't use streaming-top-n in intel gpu case #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ienkovich
reviewed
May 3, 2023
| @@ -907,10 +907,14 @@ std::unique_ptr<QueryMemoryDescriptor> build_query_memory_descriptor( | |||
| case QueryDescriptionType::Projection: { | |||
| CHECK(!must_use_baseline_sort); | |||
|
|
|||
| bool streaming_top_n_supported_by_platform = | |||
| device_type == ExecutorDeviceType::CPU || | |||
| executor->getDataMgr()->getGpuMgr()->getPlatform() != GpuMgrPlatform::L0; | |||
There was a problem hiding this comment.
I believe getGpuMgr can return nullptr.
kurapov-peter
force-pushed
the
pakurapo/streaming-top-n
branch
from
07ae22a to
ecaf20e
Compare
ienkovich
approved these changes
May 3, 2023
| @@ -907,10 +907,15 @@ std::unique_ptr<QueryMemoryDescriptor> build_query_memory_descriptor( | |||
| case QueryDescriptionType::Projection: { | |||
| CHECK(!must_use_baseline_sort); | |||
|
|
|||
| bool streaming_top_n_supported_by_platform = | |||
| device_type == ExecutorDeviceType::CPU || | |||
| (executor->getDataMgr() && executor->getDataMgr()->getGpuMgr() && | |||
There was a problem hiding this comment.
You are playing too safe, data_mgr has to be non-null
alexbaden
approved these changes
May 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the last code generation-related assertion failure we have in the L0 case.