Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Pin to Apache Arrow v11 #449

Merged
merged 2 commits into from
May 4, 2023
Merged

Pin to Apache Arrow v11 #449

merged 2 commits into from
May 4, 2023

Conversation

alexbaden
Copy link
Contributor

No description provided.

@alexbaden alexbaden requested review from leshikus and Devjiu May 2, 2023 19:56
@Devjiu
Copy link
Contributor

Devjiu commented May 3, 2023

I am not fully understand why nightly passed without this changes. https://github.com/intel-ai/hdk/actions/runs/4867852371

If pyarrow takes wrong version, so nightly should have failed.

@alexbaden
Copy link
Contributor Author

Nightly appears to have used the cached container:

2023-05-03T01:04:53.2019017Z #12 [ 8/11] RUN wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb &&     apt install -y -V ./apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb &&     apt-get update && apt-get install -y -V         libarrow-dev         libparquet-dev         libarrow-dataset-dev         libarrow-flight-dev         --
2023-05-03T01:04:53.2019887Z #12 CACHED

By changing the job names in your build, you likely invalidated the cache and got the latest arrow versions.

@Devjiu
Copy link
Contributor

Devjiu commented May 3, 2023

Ok, I see, thanks for clarification.
Maybe we should run nightly without caches to verify.

Copy link
Contributor

@Devjiu Devjiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suppose we should have single point for versions, but it's not critical for now. Should we create issue on that?

@alexbaden alexbaden merged commit c7c771d into main May 4, 2023
@alexbaden alexbaden deleted the alex/pin_arrow branch May 4, 2023 02:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants