This repository was archived by the owner on May 9, 2024. It is now read-only.
[CI] Naming #448
Merged
[CI] Naming #448
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devjiu
force-pushed
the
dmitriim/rename_with_os
branch
2 times, most recently
from
2394091 to
b67ea04
Compare
kurapov-peter
approved these changes
May 2, 2023
I think build parameters should be associated with configuration in some map-like structure. Lnx + Conda + cpu = extra_flags/extra options. From the other side it can be done as hierarchically concatenated options. |
Devjiu
force-pushed
the
dmitriim/rename_with_os
branch
from
b67ea04 to
400d3fa
Compare
gshimansky
approved these changes
May 2, 2023
|
I'm ok with it, but I do think we can spare the extra two letters to make |
Devjiu
force-pushed
the
dmitriim/rename_with_os
branch
from
400d3fa to
077ea71
Compare
This commit unifies naming after addition of Windows build. See also: #447 Signed-off-by: Dmitrii Makarenko <dmitrii.makarenko@intel.com>
Devjiu
force-pushed
the
dmitriim/rename_with_os
branch
from
077ea71 to
30af56e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit unifies naming after addition of Windows build.
See also: #447
Signed-off-by: Dmitrii Makarenko dmitrii.makarenko@intel.com