This repository was archived by the owner on May 9, 2024. It is now read-only.
Remove Unused String Dictionary Storage Code #441
Merged
+148
−1,067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ienkovich
approved these changes
Apr 28, 2023
| @@ -611,8 +421,7 @@ void StringDictionary::getOrAddBulk(const std::vector<String>& input_strings, | |||
| CHECK_LT(str_count_, MAX_STRCOUNT) | |||
| << "Maximum number (" << str_count_ | |||
| << ") of Dictionary encoded Strings reached for this column, offset path " | |||
| "for column is " | |||
| << offsets_path_; | |||
| "for column is"; | |||
| "for column is " | ||
| << offsets_path_; | ||
|
|
||
| "for column is "; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably doesn't help the lazy dictionary work that much, but I kept noticing all this unused code and decided to clear it out.
A nice side effect is we no longer create dictionary files on disk during unit tests.