This repository was archived by the owner on May 9, 2024. It is now read-only.
Cost model integration #423
Merged
+511
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurapov-peter
suggested changes
Apr 28, 2023
|
@kurapov-peter, thanks! Could you please also advice something here? I'm not sure if this is a good solution |
kurapov-peter
suggested changes
May 2, 2023
omniscidb/QueryEngine/CostModel/ExtrapolationModels/ExtrapolationModelProvider.cpp
Outdated
Show resolved
Hide resolved
Closed
kurapov-peter
suggested changes
May 5, 2023
kurapov-peter
approved these changes
May 9, 2023
omniscidb/QueryEngine/Execute.cpp
Outdated
Comment on lines
2202
to
2235
| if (needFallbackOnCPU(ra_exe_unit, requested_device_type)) | ||
| return ExecutorDeviceType::CPU; | ||
| return requested_device_type; |
There was a problem hiding this comment.
Suggested change
| if (needFallbackOnCPU(ra_exe_unit, requested_device_type)) | |
| return ExecutorDeviceType::CPU; | |
| return requested_device_type; | |
| if (needFallbackOnCPU(ra_exe_unit, requested_device_type)) { | |
| return ExecutorDeviceType::CPU; | |
| } | |
| return requested_device_type; |
bagrorg
force-pushed
the
cost_model_integration4
branch
from
683e57e to
65aed34
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the use of the
cost modelduring query execution