This repository was archived by the owner on May 9, 2024. It is now read-only.
Use a single arena per RowSetMemoryOwner. #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual memory consumption can be really out-of-control right now due to arena per core in each RowSetMemoryOwner + 4GB block size (~100MB in testing mode). That gives really huge memory consumption when ASAN is used and no visible profit (allocation is still done under the mutex).
I'd like to move to a single Arena per RowSetMemoryOwner and see how it goes. To avoid very small result set buffers placed into a single cache line, 256-bytes minimum allocation size is enforced. This should be ok because the number of allocations doesn't depend on fragment sizes, only on the number of kernels.