This repository was archived by the owner on May 9, 2024. It is now read-only.
[Cython Build] Pass all compile definitions #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devjiu
force-pushed
the
dmitriim/compile_defenitions_to_cython_target
branch
from
19f5dc0 to
94c124b
Compare
|
As currently I am changing headers like |
Devjiu
force-pushed
the
dmitriim/compile_defenitions_to_cython_target
branch
from
94c124b to
4e53440
Compare
|
@gshimansky Please, take a look, it shouldn't fail windows build, but I am not sure how to check. |
Devjiu
commented
Apr 20, 2023
python/CMakeLists.txt
Outdated
| get_property(CDEFS DIRECTORY PROPERTY COMPILE_DEFINITIONS) | ||
| get_property(IDIRS DIRECTORY PROPERTY INCLUDE_DIRECTORIES) | ||
| message(STATUS "Defintions to Cython: ${CDEFS}") | ||
| message(STATUS "Include dirs to Cython: ${IDIRS}") |
There was a problem hiding this comment.
Should I keep the messages or remove them?
ienkovich
reviewed
Apr 20, 2023
| @@ -165,7 +171,7 @@ class CUDABackend : public Backend { | |||
| llvm::TargetMachine* nvptx_target_machine); | |||
|
|
|||
| static std::unique_ptr<llvm::TargetMachine> initializeNVPTXBackend( | |||
| const CudaMgr_Namespace::NvidiaDeviceArch arch); | |||
| const CudaMgr_Namespace::NvidiaDeviceArch varch); | |||
There was a problem hiding this comment.
yes, thanks for reminder)
python/CMakeLists.txt
Outdated
| @@ -1,5 +1,10 @@ | |||
| set(SETUP_PY "${CMAKE_CURRENT_BINARY_DIR}/setup.py") | |||
|
|
|||
| get_property(CDEFS DIRECTORY PROPERTY COMPILE_DEFINITIONS) | |||
| get_property(IDIRS DIRECTORY PROPERTY INCLUDE_DIRECTORIES) | |||
| message(STATUS "Defintions to Cython: ${CDEFS}") | |||
There was a problem hiding this comment.
Please remove debug prints.
This pr passes all compile definitions from CMake to cython build. Resolves: #297 Signed-off-by: Dmitrii Makarenko <[email protected]>
This commit applies style to setup.py.in. Signed-off-by: Dmitrii Makarenko <[email protected]>
This commits wraps library/include generation into functions. Signed-off-by: Dmitrii Makarenko <[email protected]>
This commit enables build with cuda and HAVE_CUDA definition. Also passes include dirs from cmake to setup. Signed-off-by: Dmitrii Makarenko <[email protected]>
Devjiu
force-pushed
the
dmitriim/compile_defenitions_to_cython_target
branch
from
4e53440 to
bc63efc
Compare
|
Note: Only libraries parameter for all |
ienkovich
approved these changes
Apr 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr passes all compile definitions and include dirs from CMake to cython build.
Also removing dependencies to cuda from library headers.
Resolves: #297
Signed-off-by: Dmitrii Makarenko [email protected]