Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Fixed -DENABLE_JIT_DEBUG=on mode #399

Merged
merged 1 commit into from
Apr 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,11 @@ if(BUILD_SHARED_LIBS)
set(CMAKE_INSTALL_RPATH_USE_LINK_PATH ON)
endif()

option(ENABLE_JIT_DEBUG "Enable debugging symbols for the JIT" OFF)
if (ENABLE_JIT_DEBUG)
add_definitions("-DWITH_JIT_DEBUG")
endif()

# Arrow
find_package(Arrow REQUIRED)
add_definitions("-DARROW_NO_DEPRECATED_API")
Expand Down Expand Up @@ -454,4 +459,3 @@ option(ENABLE_BENCHMARKS "Build benchmarks" ON)
if (ENABLE_TESTS AND ENABLE_BENCHMARKS)
add_subdirectory(omniscidb/Benchmarks/taxi)
endif()

2 changes: 1 addition & 1 deletion omniscidb/QueryEngine/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ include_directories(${CMAKE_CURRENT_BINARY_DIR})


if (ENABLE_JIT_DEBUG AND NOT ENABLE_CUDA)
set(RT_OPT_FLAGS -O0 -g)
set(RT_OPT_FLAGS -O0 -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer)
else ()
set(RT_OPT_FLAGS -O3)
endif ()
Expand Down
2 changes: 2 additions & 0 deletions omniscidb/QueryEngine/Compiler/HelperFunctions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ void optimize_ir(llvm::Function* query_func,

pass_manager.run(*llvm_module);

#if defined(HAVE_CUDA) || defined(HAVE_L0) || !defined(WITH_JIT_DEBUG)
eliminate_dead_self_recursive_funcs(*llvm_module, live_funcs);
#endif
}
} // namespace compiler