Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Unified build flow #362

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Unified build flow #362

merged 3 commits into from
Apr 19, 2023

Conversation

kurapov-peter
Copy link
Contributor

A unified build requires both cuda and l0 dependencies installation. For that, a convenient way would be to list all the required platform dependencies as a job parameter. Unfortunately, the language doesn't support lists. Here's a simple workaround.

@kurapov-peter kurapov-peter requested a review from leshikus April 5, 2023 12:47
Copy link
Contributor

@leshikus leshikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified

This commit was signed with the committer’s verified signature.
kurapov-peter Petr Kurapov
@kurapov-peter kurapov-peter force-pushed the pakurapo/unified-build-flow branch from 3ce5b40 to 757d56d Compare April 14, 2023 13:35
@kurapov-peter kurapov-peter marked this pull request as ready for review April 14, 2023 13:35
@kurapov-peter
Copy link
Contributor Author

@alexbaden, @ienkovich, we can run this daily instead of on each PR. Thoughts?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kurapov-peter kurapov-peter merged commit 4eec6fd into main Apr 19, 2023
@kurapov-peter kurapov-peter deleted the pakurapo/unified-build-flow branch April 19, 2023 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants