This repository was archived by the owner on May 9, 2024. It is now read-only.
Fix python install #266
Merged
Fix python install #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omniscidb/scripts/conda/build.sh
Outdated
| @@ -5,5 +5,5 @@ cd $(dirname "$0")/../../.. | |||
|
|
|||
| test -z "$CC" || export CUDAFLAGS="--compiler-bindir $CC" | |||
| cmake -B build -S . $@ | |||
| cmake --build build --parallel 2 | |||
| cmake --build build --parallel `nproc` | |||
There was a problem hiding this comment.
Didn't we set it to 2 to satisfy default github runners requirements?
There was a problem hiding this comment.
- yes, we did,
- for CI this should work the same way; if someone wants to use this script locally, he may want to have more processors involved
- a year ago it was not possible to use too many processors, there were some errors related to job parallelization
leshikus
force-pushed
the
lesh/fix-python-install
branch
from
cac55b9 to
ea84dc8
Compare
alexbaden
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Looks fine to me.
@ienkovich / @kurapov-peter see any issues?
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subj