This repository was archived by the owner on May 9, 2024. It is now read-only.
Add a release artifact #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbchekin
approved these changes
Mar 5, 2023
There was a problem hiding this comment.
LGTM.
The only note that every artifact then dynamically archived to zip (when downloading? see https://github.com/actions/upload-artifact#zipped-artifact-downloads), so there is double archiving. The question is does it make sense to upload .tar only without gzipping it because later it will be zipped by GitHub. For a sake of simplicity I am proposing to keep it as is: uploading .tag.gz).
|
@pbchekin that's correct; though there is a problem that this zip archiving implementation was very slow for directories; for a small number of files it works |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subj