This repository was archived by the owner on May 9, 2024. It is now read-only.
Removed field name from initializers because MSVC thinks it is C++20 #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbaden
approved these changes
Mar 3, 2023
|
Approved too soon -- @gshimansky looks like it needs a |
Signed-off-by: Gregory Shimansky <[email protected]>
gshimansky
force-pushed
the
gregory/windows-field-names
branch
from
41f826b to
d9edd10
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC on windows doesn't allow specifying field names like this. It complains that this is a part of C++20 but enabling C++20 breaks a lot of code.