Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Remove Docs CI and add pytest #224

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Remove Docs CI and add pytest #224

merged 2 commits into from
Mar 1, 2023

Conversation

alexbaden
Copy link
Contributor

docs is no longer used and was causing failing tests on main.

I added a new pytest only run which does not include modin. The modin CI script still needs some work, since it isn't running tests properly, but I wanted to have CI that wouldn't have any possibility of using the pyhdk version from modin.

Closes #223

@alexbaden alexbaden requested review from leshikus and ienkovich March 1, 2023 01:08
@leshikus
Copy link
Contributor

leshikus commented Mar 1, 2023

With respect to pytest:

  1. this may be reworked in a way other tests work - reusing build artifact and conda env which is created by build action
  2. this has something in common with modin.yml test imho

@alexbaden
Copy link
Contributor Author

Let's just merge it so we have pytest coverage. The other tests do not build hdk from root. Modin test is different. We can improve both after we have the coverage running consistently again.

Copy link
Contributor

@ienkovich ienkovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no build artifacts to reuse right now, let's use this solution and unify later.

@alexbaden alexbaden merged commit 7179adf into main Mar 1, 2023
@alexbaden alexbaden deleted the alex/ci_updates branch March 1, 2023 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI doesn't report broken PyHDK tests
3 participants