This repository was archived by the owner on May 9, 2024. It is now read-only.
ResultSet refactoring and clean-up [01/N] #213
Merged
+0
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ienkovich <ilya.enkovich@intel.com>
alexbaden
approved these changes
Feb 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused QueryMemoryDescriptor::allow_multifrag_.
I'm starting my work on
ResultSetrefactoring. This is preparation work to makeResultSetand related structures independent of theQueryEnginelibrary. The ultimate goal is to extract structures describing memory layout and transformResultSetinto a class that holds data and provides access to it (and leaving the rest like the reduction in QueryEngine). Basically, that would be kind of an analog ofarrow::Tablebut covering all our possible output formats. All related code would go into the separate library which later will be used to createResultSetStorageto unify access to data for the QueryEngine and makeResultSeta first-class citizen, enabling queries over ResultSets (would be very useful for Modin and Python API in general where we have to convert and re-import query result to continue processing).The first part is a trivial clean-up of an unused field I noticed reading through ResultSet-related structures. I'll try to make multiple small PRs in this series rather that a single mega PR.