Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Dwarf bench integration #187

Merged
merged 11 commits into from
Feb 17, 2023

Conversation

bagrorg
Copy link
Contributor

@bagrorg bagrorg commented Feb 8, 2023

Copy of #139, removed merge to save linear history

@kurapov-peter kurapov-peter self-requested a review February 8, 2023 18:49
Copy link
Contributor

@kurapov-peter kurapov-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple comments

CMakeLists.txt Outdated
option(ENABLE_DWARF_BENCH "Enable DwarfBench library for Cost Model" OFF)
if(ENABLE_DWARF_BENCH)
find_package(dbench REQUIRED)
message("Dwarf Bench enabled")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such messages usually go to the STATUS channel. I'd also print a path to the found libraries in addition so that the message is more informative.

@kurapov-peter kurapov-peter merged commit ce6403c into intel:main Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants