This repository was archived by the owner on May 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Dwarf bench integration #187
Merged
kurapov-peter
merged 11 commits into
intel:main
from
bagrorg:dwarf_bench_integration_branch_fix
Feb 17, 2023
Merged
Dwarf bench integration #187
kurapov-peter
merged 11 commits into
intel:main
from
bagrorg:dwarf_bench_integration_branch_fix
Feb 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng for DwarfBenchDataSource
Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple comments
CMakeLists.txt
Outdated
option(ENABLE_DWARF_BENCH "Enable DwarfBench library for Cost Model" OFF) | ||
if(ENABLE_DWARF_BENCH) | ||
find_package(dbench REQUIRED) | ||
message("Dwarf Bench enabled") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such messages usually go to the STATUS
channel. I'd also print a path to the found libraries in addition so that the message is more informative.
kurapov-peter
approved these changes
Feb 15, 2023
This reverts commit f38ae96.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #139, removed
merge
to save linear history