This repository was archived by the owner on May 9, 2024. It is now read-only.
Refactor const ref args in Node classes ctors and setters. #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ienkovich <[email protected]>
ienkovich
force-pushed
the
ienkovich/remove-const-ref-vector-args-in-node-ctors
branch
from
e262656 to
2a644aa
Compare
ienkovich
deleted the
ienkovich/remove-const-ref-vector-args-in-node-ctors
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During work on
Nodeclasses, I replaced many constant reference arguments with by-value arguments. This is because constructors and setters are going to store them in the object anyway, so using by-value arguments allows a caller to avoid a copy if he decides to move-create or emplace-create arguments (he has no such option with constant reference arguments).Some constant reference cases were missed and move-construction is not always used. This minor refactoring fixes that.