This repository was archived by the owner on May 9, 2024. It is now read-only.
PRing the fixes for gcc-12 separately #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbaden
force-pushed
the
alex/gcc12_fixes
branch
from
661604d to
08ea74a
Compare
ienkovich
reviewed
Jan 9, 2023
| @@ -579,6 +579,15 @@ endif() | |||
| # RapidJSON | |||
| include_directories(ThirdParty/rapidjson) | |||
| add_definitions(-DRAPIDJSON_HAS_STDSTRING) | |||
| if(NOT MSVC) | |||
There was a problem hiding this comment.
From the comment, it looks like the fix is required for Windows but it is enabled for non-Windows builds. Also, the top level CMakeLists.txt directly includes rapidjson and therefore should require the same fix.
There was a problem hiding this comment.
I believe the fix is required for non-Windows builds -- the vcpkg version on Windows is too old for the fix to apply there as of this writing (which may have been some time ago). But, msvc doesn't seem to have an issue with the iterator format used in rapidjson -- perhaps because they are not enforcing all parts of c++17 yet?
alexbaden
force-pushed
the
alex/gcc12_fixes
branch
from
08ea74a to
72639e6
Compare
ienkovich
approved these changes
Jan 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am still struggling with conda+cuda issues, so for now PRing these separately.