This repository was archived by the owner on May 9, 2024. It is now read-only.
Fix sanity_tests run for the top-level CMakeLists #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have to use
omniscidb/CMakeLists.txt
directly to build and run sanity tests mostly due to relative paths used in tests to reach the test data and runtime libs.This PR introduces a few changes to enable tests run from the top-level build dir:
-O0
for debug build (we had a similar patch for omnisci fork)Shared
onIR
library throughtoString
methodUtil
library through globals by excluding unused code from build (don't completely remove it to probably move part of it toConfigBuilder
later)@kurapov-peter This PR finally allows us to build and run sanity_tests for HDK from any place, not necessarily from the dir created at the top of the source tree.