Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing release notes to RELEASE.md #4464

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

uday-rana
Copy link
Contributor

@uday-rana uday-rana commented Sep 23, 2024

Fixes #4458. I removed the GitHub changelogs and any references to them, since the notes for the previous releases don't include them. I also added a brief release note for release 3.4rc3 which didn't have one. Please let me know if you'd like anything changed.

@terriko
Copy link
Contributor

terriko commented Sep 23, 2024

Looks like there's some names that'll need to be added to our allow list for spelling. Here's the file that needs changing:

https://github.com/intel/cve-bin-tool/blob/main/.github/actions/spelling/allow.txt

The file is in case-insensitive alphabetical order and has an extra blank line at the end. I usually just add things at the top, sort the file with my editor, then move the blank line back to the bottom. Let us know if you get stuck!

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(See comment for requested changes for the spell checker.)

@uday-rana uday-rana force-pushed the uday-rana/issue4458 branch 2 times, most recently from 62549b1 to 4065d91 Compare September 24, 2024 00:39
@terriko
Copy link
Contributor

terriko commented Sep 24, 2024

I'm really not sure what's up with the test failures (they seem to just be getting... cut off? aborted?) so I'm going to re-run the failing tests and see if it's a persistent problem or a transient issue with Github Actions.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test failures were something on Github's end and they didn't happen when I re-ran, so we're ready to merge.

Thank you and congratulations on your first merged commit with us @uday-rana !

@terriko terriko merged commit 8b3b32c into intel:main Sep 24, 2024
21 checks passed
@uday-rana uday-rana deleted the uday-rana/issue4458 branch September 24, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE Binary Tool Release Notes page hasn't been updated for v3.3 and now v3.4 was just made
2 participants