Add the usage example and test for shared library #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
napetrov
reviewed
Apr 16, 2025
examples/cpp/shared/CMakeLists.txt
Outdated
| @@ -0,0 +1,39 @@ | |||
| # Copyright 2023 Intel Corporation | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Copyright 2023 Intel Corporation | |
| # Copyright 2025 Intel Corporation |
mihaic
reviewed
May 20, 2025
ethanglaser
approved these changes
May 20, 2025
Member
ethanglaser
left a comment
ethanglaser
left a comment
There was a problem hiding this comment.
Looks good to me. Let's confirm everything runs smoothly when its in the final state.
Member
There was a problem hiding this comment.
Not necessarily within the scope of this PR, but this utils and svsmain functionality are defined in as many as 5 different places in codebase, might be worth defining this in a single utils file to reduce duplication at some point.
examples/cpp/shared/shared.cpp
Outdated
|
|
||
| const std::filesystem::path& config_path = "./config"; | ||
| const std::filesystem::path& graph_path = "./graph"; | ||
| // const std::filesystem::path& data_path = "./data"; |
Member
There was a problem hiding this comment.
Remove/uncomment before merge
Co-authored-by: ethanglaser <[email protected]>
Co-authored-by: ethanglaser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a usage example to demonstrate how to utilize the shared library. The README has been updated to include usage instructions. The example uses shared-library-0.0.8-NIGHTLY-20250520-256-AVX512 for reference.